Woden doesn't specify the default MEP to use if none is specified

• Key: WODEN-160
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: John Kaputin
• Reporter: Lawrence Mandel
• Component/s: Parser
• Affects Version/s: M7a
• Fix Version/s: M8

Description

As reported by Jacek on the Woden mailing list (see http://mail-archives.apache.org/mod_mbox/ws-woden-dev/200705.mbox/[e-mail]%3e):

In WSDL if an operation doesn't have the pattern attribute, its MEP
seems to default to http://www.w3.org/ns/wsdl/in-out - per section 2.4.3
at
http://dev.w3.org/cvsweb/~checkout~/2002/ws/desc/wsdl20/wsdl20.html?content-type=text/html;%20charset=utf-8#InterfaceOperation_Mapping

In woden, the message exchange property is not set (line 770, rev 533754
of /incubator/woden/trunk/java/src/org/apache/woden/internal/BaseWSDLReader.java)
so this seems to be a bug.

Just adding

else {
   oper.setPattern(Constants.MEP_URI_IN_OUT);
}

should suffice.

Comments

[John Kaputin]

The parseInterfaceOperation method in BaseWSDLReader should not be changed, as this field should reflect the Element model (i.e. InterfaceOperationElement.getPattern() should return null if no MEP attribute is specified in the WSDL). Instead, the getter method on the component model should implement the defauting rule. So, InterfaceOperation.getMessageExchangePattern() should return the default value if no MEP attribute was parsed from the WSDL. I will apply this fix.

[John Kaputin]

r561298