Issue Details (XML | Word | Printable)

Key: WICKET-64
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Igor Vaynberg
Reporter: Igor Vaynberg
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Wicket

Check/Radio fail in a GridView with item reuse strategy

Created: 14/Nov/06 07:23 AM   Updated: 01/Feb/09 10:10 PM
Return to search
Component/s: wicket
Affects Version/s: 1.2.3
Fix Version/s: 1.2.4, 1.3.0-beta1, 2.0 branch (discontinued)

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works thepatch.txt 2006-11-14 07:24 AM Igor Vaynberg 26 kB
Issue Links:
Reference
 

Resolution Date: 14/Nov/06 08:00 AM


 Description  « Hide
Because check/radio use relative path from group->component as their value attribute they will lose value if that path changes. This happens when these components are used in a gridview with itemreuse strategy because the gridview has an intermediate repeater that changes the path

so the path of a check can go from

gridview:2:rowitem:5 where 2 is the id of the item of the intermediate repeater

to

gridview:3:rowitem:5

and this will cause the input value to be lost.

the solution is to use a value attribute that will not change across requests.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #474681 Tue Nov 14 07:25:21 UTC 2006 ivaynberg WICKET-64 fix check/radio when hierarchy changes
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTest.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Radio.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage1_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage3_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/tester/FormTester.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupDisabledTestPage_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/CheckGroup.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/.settings/org.eclipse.core.resources.prefs
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTest.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage1_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage2_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage3_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/Check.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage4_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupDisabledTestPage_expected.html
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/markup/html/form/RadioGroup.java

Repository Revision Date User Message
ASF #474693 Tue Nov 14 08:16:36 UTC 2006 ivaynberg WICKET-64 fix check/radio when hierarchy changes
Files Changed
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/markup/html/form/RadioGroup.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/markup/html/form/Radio.java
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupTest.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/markup/html/form/Check.java
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage1_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage2_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/util/tester/FormTester.java
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage3_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/RadioGroupDisabledTestPage_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage1_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage4_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage3_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/markup/html/form/CheckGroupDisabledTestPage_expected.html
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/markup/html/form/CheckGroup.java

Repository Revision Date User Message
ASF #475147 Wed Nov 15 07:57:36 UTC 2006 ivaynberg backport WICKET-64
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupDisabledTestPage_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/RadioGroupTestPage1_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupDisabledTestPage_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/RadioGroupTestPage3_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html/form/CheckGroup.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/main/java/wicket/util/tester/FormTester.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/RadioGroupTest.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupTestPage1_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/util/tester/FormTester.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupTestPage2_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupTestPage3_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupTestPage4_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/main/java/wicket/markup/html/form/RadioGroup.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/CheckGroupTest.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html/form
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/util
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage1_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTestPage3_expected.html
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/main/java/wicket/markup/html/form/CheckGroup.java
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/main/java/wicket/markup/html/form/Radio.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html/form/Radio.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupDisabledTestPage_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/test/java/wicket/markup/html/form/RadioGroupDisabledTestPage_expected.html
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/RadioGroupTest.java
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage1_expected.html
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage2_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/util/tester
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage3_expected.html
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTestPage4_expected.html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html/form/RadioGroup.java
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/main/java/wicket/markup/html/form/Check.java
ADD /incubator/wicket/branches/wicket-1.2.x/wicket/ws/wicket-1.2.x/src/main/java/wicket/markup/html/form/Check.java
MODIFY /incubator/wicket/branches/wicket-1.2.x/wicket/src/test/java/wicket/markup/html/form/CheckGroupTest.java