[#WICKET-35] WicketTester doesn't pass PageParameters to bookmarkable pages

Wicket

WicketTester doesn't pass PageParameters to bookmarkable pages

Created: 04/Nov/06 06:30 PM Updated: 05/Nov/06 11:16 AM

Return to search

Component/s:

wicket

Affects Version/s:

1.2.2, 1.2.3, 2.0 branch (discontinued)

Fix Version/s:

1.2.4, 2.0 branch (discontinued)

Time Tracking:

Not Specified

Resolution Date:

04/Nov/06 10:13 PM

Description

« Hide

I put BookmarkablePageLink on WebPage like this:
firstPage.add( new BookmarkablePageLink( "link", SecondPage.class, new
PageParameters( "id=1" ) ) );

and then I test it using WicketTester:
wicketTester.startPage( FirstPage.class );
wicketTester.clickLink( "link" );

The problem is that wicketTester doesn't pass PageParameters to SecondPage
(because parameters aren't passed to MockHttpServletRequest).

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Frank Bille Jensen made changes - 04/Nov/06 09:04 PM

Field	Original Value	New Value
Assignee		Frank Bille Jensen [ frankbille ]

[ Permlink | « Hide ]

Frank Bille Jensen added a comment - 04/Nov/06 09:23 PM

confirmed

Frank Bille Jensen made changes - 04/Nov/06 09:23 PM

Priority	Major [ 3 ]	Minor [ 4 ]
Component/s		wicket [ 12311420 ]

Frank Bille Jensen made changes - 04/Nov/06 10:05 PM

Affects Version/s		2.0 [ 12312113 ]
Fix Version/s		1.2.4 [ 12312138 ]
Fix Version/s		2.0 [ 12312113 ]

Repository	Revision	Date	User	Message
ASF	#471275	Sat Nov 04 22:11:25 UTC 2006	frankbille	~~WICKET-35~~ WicketTester can now test BookmarkablePageLinks with PageParameters.
				Files Changed
				MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/changes/changes.xml ADD /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/util/tester/MockPageParameterPage.html MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/tester/WicketTester.java ADD /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/util/tester/MockPageParameterPage.java MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/util/tester/WicketTesterTest.java

Repository	Revision	Date	User	Message
ASF	#471276	Sat Nov 04 22:12:34 UTC 2006	frankbille	~~WICKET-35~~ WicketTester can now test BookmarkablePageLinks with PageParameters.
				Files Changed
				MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/util/tester/WicketTester.java ADD /incubator/wicket/trunk/wicket/src/test/java/wicket/util/tester/MockPageParameterPage.html MODIFY /incubator/wicket/trunk/wicket/src/test/java/wicket/util/tester/WicketTesterTest.java ADD /incubator/wicket/trunk/wicket/src/test/java/wicket/util/tester/MockPageParameterPage.java

[ Permlink | « Hide ]

Frank Bille Jensen added a comment - 04/Nov/06 10:13 PM

Fixes are in the 1.x branch and 2.0. Can you please confirm them and then close this issue?

1.x: http://svn.apache.org/viewvc?view=rev&revision=471275
2.0: http://svn.apache.org/viewvc?view=rev&revision=471276

Frank Bille Jensen made changes - 04/Nov/06 10:13 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Frank Bille Jensen added a comment - 05/Nov/06 11:16 AM

Fix confirmed by reporter.

Frank Bille Jensen made changes - 05/Nov/06 11:16 AM

Status

Resolved [ 5 ]

Closed [ 6 ]

Repository	Revision	Date	User	Message
ASF	#477265	Mon Nov 20 17:33:06 UTC 2006	ivaynberg	~~WICKET-35~~: append AjaxTimerBehavior script to component markup. the unit test is failing because header contributions does not filter doubles.
				Files Changed
				MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/ajax/AbstractAjaxTimerBehavior.java ADD /incubator/wicket/trunk/wicket/src/test/java/wicket/ajax/AjaxTimerBehaviorTest.java

Repository	Revision	Date	User	Message
ASF	#477269	Mon Nov 20 17:41:43 UTC 2006	ivaynberg	~~WICKET-35~~: append AjaxTimerBehavior script to component markup. the unit test is failing because header contributions does not filter doubles.
				Files Changed
				ADD /incubator/wicket/branches/wicket-1.x/wicket/src/test/java/wicket/ajax/AjaxTimerBehaviorTest.java