Issue Details (XML | Word | Printable)

Key: WICKET-265
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Eelco Hillenius
Reporter: Eelco Hillenius
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Wicket

Improve diagnostics on serialization exceptions

Created: 08/Feb/07 01:07 AM   Updated: 17/Feb/07 11:33 PM
Return to search
Component/s: None
Affects Version/s: 1.3.0-beta1, 2.0 branch (discontinued)
Fix Version/s: 1.3.0-beta1, 2.0 branch (discontinued)

Time Tracking:
Not Specified

Resolution Date: 17/Feb/07 11:33 PM


 Description  « Hide
The JDK's default serialization exception doesn't give a whole lot of information other than the object that didn't implement serializable. We can try to improve on this by giving more info of the object tree that was being serialized

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #504808 Thu Feb 08 07:13:43 UTC 2007 ehillenius WICKET-265
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/protocol/http/FilePageStore.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/protocol/http/HttpSessionStore.java
ADD /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/io/DebuggingObjectOutputStream.java

Repository Revision Date User Message
ASF #504809 Thu Feb 08 07:13:57 UTC 2007 ehillenius WICKET-265
Files Changed
ADD /incubator/wicket/trunk/wicket/src/main/java/wicket/util/io/DebuggingObjectOutputStream.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/protocol/http/HttpSessionStore.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/protocol/http/FilePageStore.java

Repository Revision Date User Message
ASF #504825 Thu Feb 08 08:51:13 UTC 2007 ehillenius WICKET-265 continued
Files Changed
DEL /incubator/wicket/trunk/wicket/src/main/java/wicket/util/io/DebuggingObjectOutputStream.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/util/lang/Objects.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/protocol/http/HttpSessionStore.java
MODIFY /incubator/wicket/trunk/wicket/src/main/java/wicket/protocol/http/FilePageStore.java

Repository Revision Date User Message
ASF #504826 Thu Feb 08 08:51:26 UTC 2007 ehillenius WICKET-265 continued
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/lang/Objects.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/protocol/http/FilePageStore.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/protocol/http/HttpSessionStore.java
DEL /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/io/DebuggingObjectOutputStream.java

Repository Revision Date User Message
ASF #505654 Sat Feb 10 08:23:16 UTC 2007 ehillenius check the actual value rather than the reference. Still doesn't work though; turns out be a bit naive.
Investigate using ObjectStreamClass and friends to more closely resemble actual serialization. Also, though
the cycle check works fine for simply detecting which class offends, it is probably to simplistic currently.
I opened up WICKET-265 to work on this some more.
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/lang/Objects.java

Repository Revision Date User Message
ASF #505655 Sat Feb 10 08:26:19 UTC 2007 ehillenius check the actual value rather than the reference. Still doesn't work though; turns out be a bit naive.
Investigate using ObjectStreamClass and friends to more closely resemble actual serialization. Also, though
the cycle check works fine for simply detecting which class offends, it is probably to simplistic currently.
I opened up WICKET-265 to work on this some more.
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/protocol/http/FilePageStore.java

Repository Revision Date User Message
ASF #506199 Mon Feb 12 00:58:59 UTC 2007 ehillenius better serialization error report (WICKET-265) and turned of custom serialization by default (uncomment for development until it's really, really stable)
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/lang/Objects.java
ADD /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/io/SerializableChecker.java

Repository Revision Date User Message
ASF #506344 Mon Feb 12 07:23:42 UTC 2007 ehillenius support for Externalizable (WICKET-265)
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/io/SerializableChecker.java

Repository Revision Date User Message
ASF #506347 Mon Feb 12 07:30:51 UTC 2007 ehillenius some small improvements (WICKET-265)
Files Changed
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/lang/Objects.java
MODIFY /incubator/wicket/branches/wicket-1.x/wicket/src/main/java/wicket/util/io/SerializableChecker.java