Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Won't Fix
-
1.4-RC1
-
None
-
None
Description
I was found strange code:
In Session:
public final IPageFactory getPageFactory()
{ return getApplication().getSessionSettings().getPageFactory(); } public final IPageFactory getPageFactory(final Page page)
{
if (page != null)
return getPageFactory();
}
Both method are 'final', the first gets PageFactory from SessionSettings and the second uses Page#PageFactory (defined in Component) or uses the Session#getPageFactory() (the first method).
In Component:
/**
- @return The page factory for the session that this component is in
*/
public final IPageFactory getPageFactory() { return getSession().getPageFactory(); }
And again 'final' and gets the PageFactory by Session#getPageFactory() too.
Why is there this code? I think that the final word in Component#getPageFactory() should be removed (i need it).
Thx,
H.