[#VALIDATOR-213] Factor out Check Digit logic into separate implementations

Commons Validator

Factor out Check Digit logic into separate implementations

Created: 08/Dec/06 02:19 AM Updated: 12/Nov/07 07:25 PM

Return to search

Component/s:

Routines

Affects Version/s:

None

Fix Version/s:

1.4

Time Tracking:

Not Specified

Resolution Date:

02/Nov/07 01:51 PM

Description

« Hide

Check digit validation is embedded in the specific code validations - which also includes other validations such as format or length. This proposal is to factor out the specific check digit calculation/valdiation logic into separate implementations - making them more easily tested and re-usable.

This will include a new CheckDigit type and intially implementations for ISBN-10, EAN-13 and Luhn check digit calculation/validation

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#483781	Fri Dec 08 02:24:05 UTC 2006	niallp	~~VALIDATOR-213~~ - Factor out Check Digit logic into separate implementations
				Files Changed
				ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/CheckDigitTestSuite.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigitException.java ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigitTest.java ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigitTest.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/CheckDigitTestBase.java ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigitTest.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/package.html ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java ADD /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigitTest.java ADD /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java

Repository	Revision	Date	User	Message
ASF	#487479	Fri Dec 15 08:29:27 UTC 2006	niallp	~~VALIDATOR-213~~ Re-factor Check Digits for the following: 1) allow for Check Digits of more than one character 2) pass the left hand and right position in ModulusCheckDigit methods 3) add a getModulus() method to ModulusCheckDigit
				Files Changed
				MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigit.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigit.java MODIFY /jakarta/commons/proper/validator/trunk/src/test/org/apache/commons/validator/routines/checkdigit/CheckDigitTestBase.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/CheckDigit.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigit.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/ISBNValidator.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/ModulusCheckDigit.java MODIFY /jakarta/commons/proper/validator/trunk/src/share/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigit.java