EmailValidator allows control characters (ASCII 0-31)

• Key: VALIDATOR-190
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Niall Pemberton
• Reporter: Cott Lang
• Component/s: Routines
• Affects Version/s: 1.3.0 Release
• Fix Version/s: 1.3.1 Release

Description

EmailValidator allows ASCII 0 - 31 in an email address.

According to RFC 821, these are forbidden.

import org.apache.commons.validator.EmailValidator;

public class Test {

public static void main(String[] args) { EmailValidator ev = EmailValidator.getInstance(); String email ="\[e-mail]"; System.err.println(ev.isValid(email)); }

}

Comments

[Gabriel Belingueres]

Hi,

RFC 821 is obsoleted by RFC 2821
.
I found this one on the net what may be worth looking: RFC 2822 (Internet Message format) and RFC 2234 (Augmented BNF).

However it may well be a lot easier to post a question on the Apache Web server list.

Gabriel

[Cott Lang]

I read RFC 2821 and RFC 2822 as also forbidding control characters in email addresses as well. Maybe I'm just delusional after an exceptionally long week?

[Gabriel Belingueres]

Hi Cott,

I found this other link on the net that may be helpful. Apparently, there are some more chars that should be forbidden/discouraged to use in the local part of the email address.

It may be worth take a look at it: http://www.remote.org/jochen/mail/info/chars.html

Gabriel

[Gabriel Belingueres]

Hi,

I'm uploading the patch files that would solve the issue (ie not allowing ASCII 0..31 in the local part of the email address), along with a test case.

Gabriel

[Niall Pemberton]

I applied a slightly different change since any valid ASCII character is allowed if its quoted - so I changed the excluded "special characters" which are used to define atom/word to also exclude ascii control characters (ASCII 0-31 and 127).

http://svn.apache.org/viewvc?view=rev&revision=478560

You can test out the changes using the next nightly build:
http://people.apache.org/builds/jakarta-commons/nightly/commons-validator/

Thanks for reporting this and your help!

Niall