[#TORQUE-90] NPE in Criteria.equals when joins is null

Torque

Created: 17/Apr/07 01:18 AM Updated: 06/May/07 10:06 AM

Return to search

Component/s:

Runtime

Affects Version/s:

3.3-RC2

Fix Version/s:

3.3-RC3

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	torque-3.3-bug90-patch.diff	2007-04-17 01:20 AM	Sean Gilligan	2 kB

Environment:

Mac OS X 10.4, Java 5.0, PostgreSQL

Resolution Date:

06/May/07 10:06 AM

Description

« Hide

Criteria.equals needs to check that member "joins" is not null before calling joins.equals
A patch (with additional unit test) is attached.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

This should fix the problem and add a unit test method to check for it in th efuture.

Sean Gilligan made changes - 17/Apr/07 01:20 AM

Field	Original Value	New Value
Attachment		torque-3.3-bug90-patch.diff [ 12355658 ]

Sean Gilligan made changes - 05/May/07 10:54 PM

Component/s

Runtime [ 12310808 ]

Repository	Revision	Date	User	Message
ASF	#535591	Sun May 06 10:05:04 UTC 2007	tfischer	Fixed Null Pointer Exceptions in Criteria.equals() and Criteria.hashCode() if joins are null. Thanks to Sean Gilligan. Fixes ~~TORQUE-90~~.
				Files Changed
				MODIFY /db/torque/site/trunk/xdocs/changes.xml MODIFY /db/torque/runtime/trunk/src/java/org/apache/torque/util/Criteria.java MODIFY /db/torque/runtime/trunk/src/test/org/apache/torque/util/CriteriaTest.java

Thomas Fischer made changes - 06/May/07 10:06 AM