Issue Details (XML | Word | Printable)

Key: THRIFT-249
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Carlos Valiente
Reporter: Carlos Valiente
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Thrift

Add @param lines to Javadocs of generated service methods

Created: 05/Jan/09 10:14 PM   Updated: 06/Jan/09 08:55 PM
Return to search
Component/s: Compiler (Java)
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works THRIFT-249.patch 2009-01-05 10:15 PM Carlos Valiente 2 kB

Patch Info: Patch Available
Resolution Date: 06/Jan/09 08:55 PM


 Description  « Hide
This patch makes the Java compiler generate @param lines for the arguments of service methods which have a Thrift docstring.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Carlos Valiente added a comment - 05/Jan/09 10:15 PM
Also available via Git from git://code.pepelabs.net/thrift.git (branch 'javadocs')

Carlos Valiente made changes - 05/Jan/09 10:15 PM
Field Original Value New Value
Attachment THRIFT-249.patch [ 12397153 ]
Bryan Duxbury added a comment - 05/Jan/09 10:23 PM
Looks good to me. I say +1, commit it.

Repository Revision Date User Message
ASF #732116 Tue Jan 06 20:54:27 UTC 2009 dreiss THRIFT-249. java: Add @param lines to function docstrings
Files Changed
MODIFY /incubator/thrift/trunk/compiler/cpp/src/generate/t_java_generator.cc

David Reiss made changes - 06/Jan/09 08:55 PM
Resolution Fixed [ 1 ]
Assignee Carlos Valiente [ carlos.valiente ]
Status Open [ 1 ] Resolved [ 5 ]