Issue Details (XML | Word | Printable)

Key: TAPESTRY-935
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Andreas Andreou
Reporter: Andreas Andreou
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Tapestry

Improve BASE tag for IE

Created: 04/May/06 06:18 PM   Updated: 09/May/06 01:08 AM
Return to search
Component/s: Framework
Affects Version/s: 4.0.2, 4.0.1, 4.0
Fix Version/s: 4.1.1

Time Tracking:
Not Specified

Environment: IE 6

Resolution Date: 09/May/06 01:08 AM


 Description  « Hide
IE is very sensitive to the way the BASE tag is written. This can affect correct rendering of CSS rules + javascript execution.
See http://tacoscomponents.jot.com/BugReporter/Bug86 , http://drupal.org/node/44934 , http://mg.to/2006/04/29/your-body-is-in-your-head for more.

In a word, IE expects the BASE tag to be rendered as <base href='...'></base> .
We currently render it as <base href='...'/>

The cross-browser, XHTML + HTML4 compliant solution would render:
<base href='...'/><!--[if IE]></base><![endif]-->



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #405111 Mon May 08 18:03:54 UTC 2006 andyhot [TAPESTRY-935] Output closing base tag in IE conditional comments
Files Changed
MODIFY /tapestry/tapestry4/branches/4.0/framework/src/scripts/TestLibrary.xml
MODIFY /tapestry/tapestry4/branches/4.0/framework/src/java/org/apache/tapestry/services/impl/BaseTagWriter.java
MODIFY /tapestry/tapestry4/branches/4.0/framework/src/test/org/apache/tapestry/services/impl/TestBaseTagWriter.java
MODIFY /tapestry/tapestry4/branches/4.0/framework/src/scripts/TestSimple.xml

Repository Revision Date User Message
ASF #405359 Tue May 09 09:31:10 UTC 2006 andyhot [TAPESTRY-935] Output closing base tag in IE conditional comments
Files Changed
MODIFY /tapestry/tapestry4/branches/4.0/status.xml