Converter property of contrib:FormTable does not work

• Key: TAPESTRY-241
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Jesse Kuhnert
• Reporter: Kurtis Williams
• Component/s: Contrib
• Affects Version/s: 3.0.1
• Fix Version/s: 3.0.5

Description

I've been trying to use the "converter" property on the contrib:FormTable component without success. I dug into the source code and discovered that the "converter" property on the contained "tableRows" components is not marked as <inherited-binding.../>, it's just marked as a <binding.../> which, of course, will prevent the "converter" property of the owning table from being passed in properly. This all happens on line 237 of FormTable.jwc:
 
<component id="tableRows" type="TableFormRows">
  <inherited-binding name="row" parameter-name="row"/>
  <inherited-binding name="class" parameter-name="rowsClass"/>
  <!-HERE'S THE PROBLEM!!!-->
  <binding name="convertor" expression="convertor"/>
</component>

It seems like that line should read:

<inherited-binding name="converter" expression="converter"/>

Comments

[Brian K. Wallace]

While the binding change (from binding to inherited-binding) logic is correct, the property is actually "convertor" ("or", not "er").

[Jesse Kuhnert]

patch applied, thanks