[#STR-2826] If a field's display property is set to 'none' using CSS or JavaScript, the focus code fails.

Struts 1

If a field's display property is set to 'none' using CSS or JavaScript, the focus code fails.

Created: 08/Apr/06 04:44 AM Updated: 28/Apr/06 11:48 PM

Component/s:

Tag Libraries

Affects Version/s:

1.2.9

Fix Version/s:

1.3.3

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	focusControl_css_dispay_bug_fix.patch	2006-04-08 04:44 AM	Zarar Siddiqi	0.2 kB

Environment:

« Hide

Operating System: other
Platform: Other

Bugzilla Id:	39249
Resolution Date:	28/Apr/06 11:59 AM
Labels:

Description

« Hide

If a field's display property is set to 'none' using CSS or JavaScript, the
current code still tries to give the field focus which will result in an error
in IE.

A patch is for the org.apache.struts.taglib.html.FormTag.java file and is attached:

663c663
< " if (focusControl.type != \"hidden\" && !focusControl.disabled) {");
---
> " if (focusControl.type != \"hidden\" && !focusControl.disabled
&& focusControl.style.display != \"none\") {");

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permalink | « Hide ]

Zarar Siddiqi added a comment - 08/Apr/06 04:44 AM

Created an attachment (id=18044)
Patch to apply to org.apache.struts.taglib.html.FormTag to fix focus() bug.

[ Permalink | « Hide ]

Don Brown added a comment - 28/Apr/06 11:59 AM

The patch has been applied against trunk, so give it a shot and close the ticket if you found it fixed. Thanks for the patch!

[ Permalink | « Hide ]

Zarar Siddiqi added a comment - 28/Apr/06 10:28 PM

This worked for me. Thanks. Can't find the option to 'close' this issue so I'll leave that to you...