Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2747

Make the windowing classes use long instead of int for time parameters, and rename millisecond based time parameters so it's clear which unit they are.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 2.0.0, 1.1.1, 1.0.5
    • None
    • None
    • None

    Description

      Some parameters in the windowing classes are using int instead of long for describing time, which requires a bunch of casting to/from long in the code. Some variables are always in milliseconds but are named e.g. "value", which makes it easy to accidentally use the wrong timeunit. Such variables should be named e.g. "valueMs" to disambiguate the unit.

      Attachments

        Activity

          People

            Unassigned Unassigned
            srdo Stig Rohde Døssing
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: