[STORM-2343] New Kafka spout can stop emitting tuples if more than maxUncommittedOffsets tuples fail at once

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0.0, 1.1.0
• Fix Version/s: 2.0.0, 1.1.1, 1.2.0
• Component/s: storm-kafka-client
• Epic Link: Release Apache Storm 1.1.0
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 03/Feb/17 23:52
• Updated: 03/Jul/17 15:03
• Resolved: 21/May/17 09:55

Description

It doesn't look like the spout is respecting maxUncommittedOffsets in all cases. If the underlying consumer returns more records in a call to poll() than maxUncommittedOffsets, they will all be added to waitingToEmit. Since poll may return up to 500 records by default (Kafka 0.10.1.1), this is pretty likely to happen with low maxUncommittedOffsets.

The spout only checks for tuples to retry if it decides to poll, and it only decides to poll if numUncommittedOffsets < maxUncommittedOffsets. Since maxUncommittedOffsets isn't being respected when retrieving or emitting records, numUncommittedOffsets can be much larger than maxUncommittedOffsets. If more than maxUncommittedOffsets messages fail, this can cause the spout to stop polling entirely.

Issue Links

• relates to: STORM-2549 The fix for STORM-2343 is incomplete, and the spout can still get stuck on failed tuples
• links to: GitHub Pull Request #1924
• links to: GitHub Pull Request #2022