Issue Details (XML | Word | Printable)

Key: STDCXX-602
Type: Improvement Improvement
Status: Reopened Reopened
Priority: Trivial Trivial
Assignee: Unassigned
Reporter: Martin Sebor
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
C++ Standard Library

remove std::stringbuf::_C_grow()

Created: 17/Oct/07 09:44 PM   Updated: 11/Jul/09 12:06 AM
Return to search
Component/s: 27. Input/Output
Affects Version/s: 4.2.0
Fix Version/s: 4.3.0

Time Tracking:
Original Estimate: Not Specified
Remaining Estimate: 0h
Time Spent - 1h
Time Spent: 1h
Time Spent - 1h

Environment: all

Severity: Cosmetic


 Description  « Hide
...the function is inline and only called from std::stringbuf::str(). Removing it (by virtue of expanding its body into str()) will reduce the number of symbols "exported" from the library and decrease the risk of breaking binary compatibility (see STDCXX-142 and the discussion thread at http://www.nabble.com/difference-in-exported-symbols-between-4.1.3-and-4.2.0-15d-dll%27s-%28MSVC-7.1%29-tf4641636.html)

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #629207 Tue Feb 19 19:55:21 UTC 2008 vitek 2008-02-19 Travis Vitek <vitek@roguewave.com>

STDCXX-602
* include/sstream (_C_grow): Remove declaration and definition of
private method.
* include/sstream.cc (str): Calculate the appropriate buffer size
directly, removing call to removed method _C_grow().
Files Changed
MODIFY /stdcxx/trunk/include/sstream
MODIFY /stdcxx/trunk/include/sstream.cc

Repository Revision Date User Message
ASF #629212 Tue Feb 19 20:05:45 UTC 2008 vitek 2008-02-19 Travis Vitek <vitek@roguewave.com>

STDCXX-602
* include/sstream.cc (str): Fix compile error and signed/unsigned
warning introduced in previous change.
Files Changed
MODIFY /stdcxx/trunk/include/sstream.cc

Repository Revision Date User Message
ASF #652711 Thu May 01 23:38:56 UTC 2008 vitek 2008-05-01 Travis Vitek <vitek@roguewave.com>

STDCXX-602
* include/sstream (_C_grow): Revert r629207 to avoid any
backward binary compatibility problems.
* include/sstream.cc (str): Ditto.
Files Changed
MODIFY /stdcxx/branches/4.3.x/include/sstream
MODIFY /stdcxx/branches/4.3.x/include/sstream.cc