remove std::stringbuf::_C_grow()

• Key: STDCXX-602
• Type: Improvement
• Status: Reopened
• Priority: Trivial
• Assignee: Unassigned
• Reporter: Martin Sebor
• Component/s: 27. Input/Output
• Affects Version/s: 4.2.0
• Fix Version/s: 4.3.0

Description

...the function is inline and only called from std::stringbuf::str(). Removing it (by virtue of expanding its body into str()) will reduce the number of symbols "exported" from the library and decrease the risk of breaking binary compatibility (see STDCXX-142 and the discussion thread at http://www.nabble.com/difference-in-exported-symbols-between-4.1.3-and-4.2.0-15d-dll%27s-%28MSVC-7.1%29-tf4641636.html)

Comments

[Martin Sebor]

Now that 4.2.0 is released, set Affects Version(s) accordingly.

[Travis Vitek]

Committed to trunk in r629207

[Travis Vitek]

Then fixed on trunk in r629212.

I'm not sure how we ended up with 4.2.1 for Fix Version/s but this isn't binary compatible, is it?

[Travis Vitek]

Ah, you beat me to it. I was waiting for the commit to show up in the mail archives so I could reply with this same question there. Yes, the method _C_grow() is exported from the shared library, so this is likely a binary compatibility issue.

Unless someone indicates otherwise, I'm going to leave the fix on trunk and then set the fix version of this issue to 4.3.

[Travis Vitek]

Updated fix version o 4.3

[Travis Vitek]

This fix was committed to the 4.3 branch when the branch was created. It has been tested on trunk, so it is safe to close.

[Martin Sebor]

If the removal wasn't compatible before what makes it compatible now?

[Travis Vitek]

Whoa. Had I reviewed the versioning policy I would have remembered that 4.3 is supposed to be binary backward compatible with 4.2.x. This change is not backward compatible at all, so it needs to be removed from 4.3. Thank you for the gentle reminder.