Issue Details (XML | Word | Printable)

Key: STDCXX-563
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Farid Zaripov
Reporter: Martin Sebor
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
C++ Standard Library

split up rw/_mutex.h

Created: 18/Sep/07 05:59 PM   Updated: 13/Oct/08 04:45 PM
Return to search
Component/s: Build and Installation
Affects Version/s: 4.2.0
Fix Version/s: 4.2.2

Time Tracking:
Original Estimate: 4h
Original Estimate - 4h
Remaining Estimate: 0h
Time Spent - 4h
Time Spent: 4h
Time Spent - 4h

File Attachments:
  Size
Text File Licensed for inclusion in ASF works stdcxx-563.patch 2008-05-15 03:33 PM Farid Zaripov 119 kB

Patch Info: Patch Available
Severity: Cosmetic
Resolution Date: 17/Sep/08 01:50 PM


 Description  « Hide
The internal header <rw/_mutex.h> has become too big and hard to maintain. It would be an improvement to split it up into multiple headers, one for each supported implementation of threads, along the lines of what was done with the <rw/_config.h> header in http://svn.apache.org/viewvc?view=rev&revision=382600. This is too big to do for 4.2 but simple enough that it could go in 4.2.1.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Martin Sebor made changes - 01/Nov/07 12:09 AM
Field Original Value New Value
Affects Version/s trunk [ 12312676 ]
Affects Version/s 4.2 [ 12311945 ]
Martin Sebor made changes - 14/Mar/08 04:29 AM
Assignee Farid Zaripov [ farid ]
Martin Sebor made changes - 18/Mar/08 05:56 PM
Severity Cosmetic
Remaining Estimate 4h [ 14400 ]
Original Estimate 4h [ 14400 ]
Farid Zaripov made changes - 19/Mar/08 02:16 PM
Status Open [ 1 ] In Progress [ 3 ]
Farid Zaripov made changes - 19/Mar/08 04:20 PM
Attachment stdcxx-563.patch [ 12378251 ]
Farid Zaripov made changes - 24/Mar/08 05:27 PM
Attachment stdcxx-563.patch [ 12378251 ]
Farid Zaripov made changes - 24/Mar/08 05:41 PM
Attachment stdcxx-563.patch [ 12378495 ]
Farid Zaripov made changes - 24/Mar/08 05:41 PM
Patch Info [Patch Available]
Farid Zaripov made changes - 24/Mar/08 05:41 PM
Status In Progress [ 3 ] Open [ 1 ]
Martin Sebor made changes - 23/Apr/08 05:29 AM
Fix Version/s 4.2.1 [ 12312690 ]
Fix Version/s 4.2.2 [ 12313096 ]
Martin Sebor made changes - 05/May/08 05:26 PM
Priority Major [ 3 ] Minor [ 4 ]
Farid Zaripov made changes - 15/May/08 03:14 PM
Attachment stdcxx-563.patch [ 12378495 ]
Farid Zaripov made changes - 15/May/08 03:14 PM
Attachment stdcxx-563.patch [ 12382117 ]
Farid Zaripov made changes - 15/May/08 03:21 PM
Comment [ The updated patch is attached.

{noformat}
  ChangeLog:
  STDCXX-563
  * include/rw/_atomic.h: New header file with definitions of inline functions
  for atomic operations.
  * include/rw/_atomic_aplha.h: New header file with definitions of inline
  functions for atomic operations on ALPHA platform.
  * include/rw/_atomic_generic.h: New header file with definitions of generic
  inline functions for atomic operations with long and long long types.
  * include/rw/_atomic_ia64_x64.h: New header file with definitions of inline
  functions for atomic operations on Intel IA64 and X64 platforms.
  * include/rw/_atomic_mips.h: New header file with definitions of inline functions
  for atomic operations on MIPS platform.
  * include/rw/_atomic_mutex.h: New header file with definitions of inline functions
  for atomic operations with using mutex object.
  * include/rw/_atomic_parisc.h: New header file with definitions of inline functions
  for atomic operations on PA RISC platform.
  * include/rw/_atomic_powerpc.h: New header file with definitions of inline functions
  for atomic operations on POWERPC platform.
  * include/rw/_atomic_sparc.h: New header file with definitions of inline functions
  for atomic operations on SPARC platform.
  * include/rw/_atomic_x86.h: New header file with definitions of inline functions for
  atomic operations on Intel X86 platform.
  * include/rw/_mutex_dce.h: New header file with definitions of classes for thread
  safety using DCE threads.
  * include/rw/_mutex_os2.h: New header file with definitions of classes for thread
  safety using OS2 threads.
  * include/rw/_mutex_pthread.h: New header file with definitions of classes for thread
  safety using POSIX threads.
  * include/rw/_mutex_solaris.h: New header file with definitions of classes for thread
  safety using Solaris threads.
  * include/rw/_mutex_windows.h: New header file with definitions of classes for thread
  safety using Windows threads.
  * include/rw/_mutex.h: Split content of the file to the set of platform specific and OS
  specific headers above.
  (__rw_get_static_mutex) [!_RWSTD_NO_ATOMIC_OPS && !_PA_RISC2_0]: Declare
  __cntr as int instead of volatile long (see STDCXX-792), use
  _RWSTD_ATOMIC_PREINCREMENT() on all platforms where atomic increment is
  available instead of using InterlockedIncrement() only on Windows.
{noformat}
]
Farid Zaripov made changes - 15/May/08 03:23 PM
Remaining Estimate 4h [ 14400 ] 0h [ 0 ]
Time Spent 4h [ 14400 ]
Farid Zaripov made changes - 15/May/08 03:32 PM
Attachment stdcxx-563.patch [ 12382117 ]
Farid Zaripov made changes - 15/May/08 03:33 PM
Attachment stdcxx-563.patch [ 12382120 ]
Farid Zaripov made changes - 15/May/08 03:36 PM
Assignee Farid Zaripov [ farid ]
Farid Zaripov made changes - 17/Sep/08 01:50 PM
Assignee Farid Zaripov [ farid ]
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]