Issue Details (XML | Word | Printable)

Key: STDCXX-560
Type: Sub-task Sub-task
Status: Resolved Resolved
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Travis Vitek
Reporter: Martin Sebor
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
C++ Standard Library
STDCXX-552

add ASL headers to all config tests

Created: 18/Sep/07 12:56 AM   Updated: 01/Oct/07 06:36 PM
Return to search
Component/s: Release
Affects Version/s: None
Fix Version/s: 4.2.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works compiler-config.patch 2007-09-18 01:52 AM Travis Vitek 17 kB
Text File Licensed for inclusion in ASF works config-tests.patch 2007-09-18 01:52 AM Travis Vitek 304 kB
Text File Licensed for inclusion in ASF works configure.patch 2007-09-18 01:52 AM Travis Vitek 2 kB
Text File Licensed for inclusion in ASF works missed-config.patch 2007-09-24 04:35 PM Travis Vitek 1 kB

Patch Info: Patch Available
Resolved: 20/Sep/07 04:58 PM
Resolution Date: 01/Oct/07 06:36 PM


 Description  « Hide
According to the ASF Source Header and Copyright Notice Policy (http://www.apache.org/legal/src-headers.html), all human-readable Apache-developed files that are included within a distribution must include ASL header text. None of the source files for our config tests currently does. These headers need to be added in time for the 4.2.0 release.

Note that since in the config tests, the first line is reserved for the "label" displayed by GNUMakefile.cfg before compiling the test, the headers cannot start on the first line. Instead, it should be fine to append the header to the end of every config test instead.

Since the above mentioned policy applies to releases distributed after November 1, 2006, this task affects trunk only (and not any already published releases or snapshots).



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Travis Vitek added a comment - 18/Sep/07 01:52 AM
patches for the configuration tests, the compiler config scripts, and generate/configure.bat.

Note: I can't find the location that I read it, but the license header is supposed to be near the top of the file. I can't find a source for that information, but I did read it today while researching the requirements.


Martin Sebor added a comment - 18/Sep/07 05:01 AM
I've successfully tested with gcc on Linux compiler-config.patch and config-tests.patch and committed both. I don't have access to Windows. Farid, can you test the last Windows-only configure.patch and, assuming it checks out, commit it?

Martin Sebor added a comment - 19/Sep/07 09:26 PM
Assigned to Farid.

Farid, please set the issue to Resolved after you've tested the last (Windows-only) patch. We'll close it once RAT confirms that all the files are properly licensed.


Martin Sebor added a comment - 20/Sep/07 04:53 AM
Patches are available.

Farid Zaripov added a comment - 20/Sep/07 08:02 AM
Tested on Windows and no problems were found.

Farid Zaripov added a comment - 20/Sep/07 04:37 PM
etc/config/windows/*.config files should also have the ASL headers.

Travis Vitek added a comment - 21/Sep/07 08:24 PM
One more config test...

2007-09-21 Travis Vitek <vitek@roguewave.com>

STDCXX-560

  • MADVISE.cpp: Add ASL header

Travis Vitek added a comment - 01/Oct/07 04:28 PM
Additional patch is required.