|
[
Permlink
| « Hide
]
Martin Sebor added a comment - 13/Sep/07 12:58 AM
This is a Release Management issue: set component to Release.
The query below might be helpful to understand what the Incubator PMC is looking for when they run the tool:
http://www.nabble.com/forum/Search.jtp?forum=378&local=y&query=rat  Running RAT should help verify the completeness of
Attach RAT output for entire 4.2.0 tree.
Great, the output will be helpful!
Could you also paste in step-by-step instructions on how you set up the tool and ran it to get the output so someone else can do it the next time around if need be? Also, regarding the documentation HTML files, can you find out how the license notice needs to be embedded? E.g., are we expected to an HTML comment to each page with the license or something else? (I'm sure the ASF doesn't expect each HTML page to have the license header on it.)
Answer to first question, Instructions for using RAT.
1. download and install java if necessary http://java.sun.com As for the second question, I found the following [from http://www.apache.org/legal/src-headers.html] What if my project includes its web site within a product distribution? What files in an Apache release do not require a license header? I also found some discussion http://www.nabble.com/Rat-tool%2C-Apache-header-and-different-file-types-tf2352902.html#a6553062 Okay, that's pretty conclusive: every documentation file needs to contain a comment with the ASL header in it. Let me create a subtask for it. It also sounds like every config test (under etc/config/src) must contain such a comment, as do the files under etc/nls/. I'll create another subtask for those. What should not (and cannot) contain such headers is the .in and .out files under the examples/ directory tree.
There are a few more patches that need to be applied for this case to be considered closed. I'm linking to the issues here.
http://issues.apache.org/jira/browse/STDCXX-560 Once those are submitted, the rat-stdcxx-4.2.0-v1 results will be correct. The only files that don't have ASL headers are 'gen_list', 'codeset_aliases' and the .in/.out files for the examples. Travis, could you please attach the output of RAT on the latest release candidate for the record?
Also, when mentioning an issue (such as Apparently I have to reopen to add files.
Here is the list of files without the ASL header.
C:\Rat>java -jar rat-0.5.1.jar c:\Build\stdcxx-4.2.0-rc5 | find "!?????" | find /v ".out" | find /v ".in" Of those, only gen_list and codeset_aliases are actually expected to not have the ASL header. The others apparently have not been integrated from trunk. I've just merged the latest trunk/doc to branches/4.2.0/doc: http://svn.apache.org/viewvc?rev=584901&view=rev
I'm not sure gen_list or codeset_aliases allow for comments. If they do, we should add the header. Otherwise there's nothing we can do for 4.2.0 (but remember to extend the locale utilities in 4.2.1 to accept comments. The code that reads the gen_list file doesn't appear to process comments. I couldn't actually find anything that referenced the codeset_aliases file, so it may be garbage left behind [the code in aliases.cpp used by utilitiy binaries defines its own aliases list internally].
Thanks, Travis. I think we can consider the issue fully resolved. Closing as Fixed.
It seems, that 75 files in stdcxx-4.2.0-rc-7 are contains the previous ASL header:
$ grep -r "Licensed under" /usr/src/stdcxx-4.2.0-rc-7/* >grep.out See the attached grep.out file. The "old" ASL header should be updated but (as I mention below) since RAT doesn't complain it's not a blocker for 4.2.0.
http://www.nabble.com/RE%3A--VOTE-RESULT--release-stdcxx-4.2.0-%28candidate-7%29-p13431011.html Let's keep this closed. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Task
Closed
Blocker
run RAT on stdcxx 4.2.0
