std::numpunct not thread safe

• Key: STDCXX-452
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Blocker
• Assignee: Travis Vitek
• Reporter: Martin Sebor
• Component/s: 22. Localization, Thread Safety
• Affects Version/s: 4.1.2, 4.1.3
• Fix Version/s: 4.2.0

Description

The 22.locale.numpunct.mt thread safety tests aborts at runtime indicating that there is a thread safety issue in the locale implementation. Running the test through the Intel Thread Checker reveals possible causes of the problem.

$ tcheck_cl -v && make 22.locale.numpunct.mt && tcheck_cl -f html -o 22.locale.numpunct.mt ./22.locale.numpunct.mt --nthreads=2 --nloops=1000
Intel(R) Thread Checker 3.1 command line instrumentation driver (24400)
Copyright (c) 2007 Intel Corporation. All rights reserved.
make: `22.locale.numpunct.mt' is up to date.
Intel(R) Thread Checker 3.1 command line instrumentation driver (24400)
Copyright (c) 2007 Intel Corporation. All rights reserved.
Building project

Running: /build/sebor/stdcxx-icc-9.1_049-15S/tests/22.locale.numpunct.mt --nthreads=2 --nloops=1000

1. INFO (S1) (10 lines):
2. TEXT:
3. COMPILER: Intel C++, _INTEL_COMPILER = 910, __INTEL_COMPILER_BUILD_DATE = 20070320, __EDG_VERSION_ = 306
4. ENVIRONMENT: x86_64/LP64 running linux-elf 2.4.20 with glibc 2.3
5. FILE: 22.locale.numpunct.mt.cpp
6. COMPILED: Jun 13 2007, 14:05:31
7. COMMENT: thread safety
   ############################################################

1. CLAUSE: lib.locale.numpunct

1. NOTE (S2) (5 lines):
2. TEXT: executing "locale -a > /tmp/tmpfile-FZLyTh"
3. CLAUSE: lib.locale.numpunct
4. FILE: process.cpp
5. LINE: 274

1. INFO (S1) (3 lines):
2. TEXT: testing std::numpunct<charT> with 2 threads, 1000 iterations each, in locales { "aa_DJ" "aa_DJ.iso88591" "aa_DJ.utf8" "aa_ER" "aa_ER@saaho" "aa_ER.utf8" "aa_ER.utf8@saaho" "aa_ET" "aa_ET.utf8" "af_ZA" "af_ZA.iso88591" "af_ZA.utf8" "am_ET" "am_ET.utf8" "an_ES" "an_ES.iso885915" "an_ES.utf8" "ar_AE" "ar_AE.iso88596" "ar_AE.utf8" "ar_BH" "ar_BH.iso88596" "ar_BH.utf8" "ar_DZ" "ar_DZ.iso88596" "ar_DZ.utf8" "ar_EG" "ar_EG.iso88596" "ar_EG.utf8" "ar_IN" "ar_IN.utf8" "ar_IQ" }
3. CLAUSE: lib.locale.numpunct

1. INFO (S1) (3 lines):
2. TEXT: exercising std::numpunct<char>
3. CLAUSE: lib.locale.numpunct

/amd/devco/sebor/stdcxx/tests/localization/22.locale.numpunct.mt.cpp:128: void *thread_func(void *): Assertion '0 == rw_strncmp (fn.c_str (), data->falsename_)' failed.
/build/sebor/stdcxx-icc-9.1_049-15S/tests/./22.locale.numpunct.mt[0x8ad9fc]

Application finished

Comments

[Martin Sebor]

Attached Intel Thread Checker output.

Added Thread Safety to the list of components affected by this issue.

[Martin Sebor]

Scheduled for 4.2.

[Travis Vitek]

2007-09-28 Travis Vitek <[e-mail]>

STDCXX-452

• punct.cpp (__rw_get_numpunct): After creating __rw_setlocale
  object check if the locale data is initialized by another thread
  to avoid doing unnecessary work and leaking memory.

[Martin Sebor]

Merged to trunk in r580979.