[Cygwin] util does not compile clean and fails to link

• Key: STDCXX-40
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Farid Zaripov
• Reporter: Lance Diduck
• Component/s: Utilities
• Affects Version/s: 4.1.2
• Fix Version/s: 4.2.0

Description

gcc -c -I/cygdrive/c/temp/stdcxx2/include/ansi -D_RWSTDDEBUG -D_RWSTD_USE_CONFIG -I/cygdrive/c/temp/stdcxx2/11sgcc2/include -I/cygdrive/c/temp/stdcxx2/include -I/cygdrive/c/temp/stdcxx2/include/loc -pedantic -nostdinc++ -g -Wall -W -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align /cygdrive/c/temp/stdcxx2/util/localedef.cpp
/cygdrive/c/temp/stdcxx2/util/localedef.cpp: In function `bool process_command_l
ine(ProgramOptions*, int, char**)':
/cygdrive/c/temp/stdcxx2/util/localedef.cpp:467: warning: unused variable 'errors'

gcc localedef.o aliases.o charmap.o codecvt.o collate.o ctype.o def.o diagnostic.o messages.o monetary.o numeric.o path.o time.o scanner.o -o localedef -L/cygdrive/c/temp/stdcxx2/11sgcc2/lib -lstd11s -lsupc++ -lm
charmap.o: In function `ZNSt4pairIKwSsEC1ERKS1':
/cygdrive/c/temp/stdcxx2/include/rw/_specialized.h.text+0x4c0): undefined reference to `_libiconv_open'
charmap.o: In function `_ZNK7Charmap15convert_to_utf8EPKcjPcj':
/cygdrive/c/temp/stdcxx2/util/charmap.cpp:346: undefined reference to `_libiconv
'

gcc -c -I/cygdrive/c/temp/stdcxx2/include/ansi -D_RWSTDDEBUG -D_RWSTD_USE_CONFIG -I/cygdrive/c/temp/stdcxx2/11sgcc2/include -I/cygdrive/c/temp/stdcxx2/include -I/cygdrive/c/temp/stdcxx2/include/loc -pedantic -nostdinc++ -g -Wall -W -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align /cygdrive/c/temp/stdcxx2/util/charmap.cpp
/cygdrive/c/temp/stdcxx2/util/charmap.cpp: In member function `wchar_t Charmap::increment_val(wchar_t) const':
/cygdrive/c/temp/stdcxx2/util/charmap.cpp:422: warning: converting of negative value `-0x000000001' to `wchar_t'
/cygdrive/c/temp/stdcxx2/util/charmap.cpp: In member function `wchar_t Charmap::convert_sym_to_ucs(const std::string&) const':
/cygdrive/c/temp/stdcxx2/util/charmap.cpp:497: warning: comparison between signed and unsigned integer expressions

gcc -c -I/cygdrive/c/temp/stdcxx2/include/ansi -D_RWSTDDEBUG -D_RWSTD_USE_CONFIG -I/cygdrive/c/temp/stdcxx2/11sgcc2/include -I/cygdrive/c/temp/stdcxx2/include -I/cygdrive/c/temp/stdcxx2/include/loc -pedantic -nostdinc++ -g -Wall -W -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align /cygdriv
e/c/temp/stdcxx2/util/ctype.cpp
/cygdrive/c/temp/stdcxx2/util/ctype.cpp: In function `wchar_t convert_literal_to_ucs4(Scanner::token_t&)':
/cygdrive/c/temp/stdcxx2/util/ctype.cpp:47: warning: comparison between signed and unsigned integer expressions

Comments

[Lance Diduck]

Adding -liconv to LDLIBS in makefile.in allows it to link

[Martin Sebor]

That sounds like a fix unless libiconv is optional with Cygwin. In that case we should probably avoid relying on it. The utilities only need it for portability with the libc locales on the system so when there's no libiconv we don't need to worry about it. But making it optional isn't probably going to be completely straightforward.

[Martin Sebor]

Lowered priority since on Cygwin the issue can be trivially dealt with simply by installing libiconv. Note that this issue should be considered in conjunction with STDCXX-404 which doesn't look like it has such as simple solution.

[Martin Sebor]

Reassigned to Farid.

[Martin Sebor]

Scheduled for 4.2.0.

[Farid Zaripov]

No problem with building the utils on cygwin with iconv installed.