[gcc/Mac OS X] link utilities with the iconv library

• Key: STDCXX-357
• Type: Improvement
• Status: Resolved
• Resolution: Invalid
• Priority: Minor
• Assignee: Eric Lemings
• Reporter: Eric Lemings
• Component/s: Utilities
• Affects Version/s: 4.1.2, 4.1.3
• Fix Version/s: 4.2.2

Description

Some executables (esp. locale-specific utilities) need to link with the iconv library. Patch listed below. (Don't think it will matter that the link flag is given for all link commands.)

Index: etc/config/gcc.config
===================================================================
--- etc/config/gcc.config       (revision 517771)
+++ etc/config/gcc.config       (working copy)
@@ -127,7 +129,7 @@
   ifeq ($(OSNAME),Darwin)
     # link with gcc_eh to resolve the _Unwind_xxx functions
     # (shouldn't we link with it on all platforms?)
-    LDLIBS += -lgcc_eh
+    LDLIBS += -liconv -lgcc_eh
   endif
 endif   # gcc > 2

Comments

[Martin Sebor]

I have successfully built the locale utilities with gcc 4.01 on Darwin 8.10.1 w/o iconv (with _RWSTD_NO_ICONV #defined in the config header), probably as a result of http://svn.apache.org/viewvc?view=rev&revision=579018. We should revisit this in the future to see if linking with libiconv provides additional functionality that we might be missing out on now.

[Martin Sebor]

Changed Issue Type to Improvement, Component(s) to Utilities, set Priority to Minor, and scheduled for 4.2.1.

[Martin Sebor]

Disabled formatting. Patch is available inline.

[Martin Sebor]

Brad, can you check if the patch is still good an needed?

Btw., it would be nice if you could put together a list of the programs that need to link with libiconv and show what happens when they don't (linker errors? runtime problems? ...)

[Eric Lemings]

I believe this issue is no longer relevant (as the locale utilities seeminly link without a hitch) but I'm running into other problems while building so I'm not 100% sure of this.

[Eric Lemings]

I built the latest snapshot of trunk on both Tiger and Leopard, reviewed the build results, and did some test runs of the locale-related utilities. Found no evidence of these link errors nor any runtime errors. Going to close this issue. (Note to self: Give enough detail to reproduce the exact failure next time!)

[Eric Lemings]

I just ran into this again (or something similar).

[Eric Lemings]

After further investigation, the error observed is related to a specific test rather than the linking in general. Will create a new issue to address the error.