[SSHD-31] Change ClientSessionImpl SshClient constructor argument from SshClient to FactoryManager

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.2.0
• Environment: N/A
• Assignee: Guillaume Nodet
• Reporter: Pete Torgenrud
• Created: 27/Jun/09 21:18
• Updated: 27/Jul/09 07:58
• Resolved: 27/Jul/09 07:58

Description

ClientSessionImpl takes SshClient as an argument and passes it to AbstractSession (which is its super). AbstractSession stores this as FactoryManager type and I cannot see that the argument is used as SshClient type.

Suggest changing ClientSessionImpl constructor SshClient argument to FactoryManager so it's possible to extend AbstractFactoryManager to implement custom client functionality and thus re-use ClientSessionImp.

I've marked this as minor since it's possible to implement custom client functionality by extending SshClient, but the API becomes more general with the change.