Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-25745

docker-image-tool.sh ignores errors from Docker

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.3.0, 2.3.1, 2.3.2
    • 3.0.0
    • Deploy, Kubernetes, Spark Core
    • None

    Description

      In attempting to use the docker-image-tool.sh scripts to build some custom Dockerfiles I ran into issues with the scripts interaction with Docker. Most notably if the Docker build/push fails the script continues blindly ignoring the errors. This can either result in complete failure to build or lead to subtle bugs where images are built against different base images than expected.

      Additionally while the Dockerfiles assume that Spark is first built locally the scripts fail to validate this which they could easily do by checking the expected JARs location. This can also lead to failed Docker builds which could easily be avoided.

      Attachments

        Activity

          People

            rvesse Rob Vesse
            rvesse Rob Vesse
            Yinan Li Yinan Li
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: