[SPARK-25058] Use Block.isEmpty/nonEmpty to check whether the code is empty or not.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: SQL
• Assignee: Takuya Ueshin
• Reporter: Takuya Ueshin
• Created: 08/Aug/18 17:07
• Updated: 09/Aug/18 05:07
• Resolved: 09/Aug/18 05:07

Description

We should use Block.isEmpty/nonEmpty instead of comparing with empty string to check whether the code is empty or not.

[error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala:278: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely always compare unequal
[error] [warn]       if (ev.code != "" && required.contains(attributes(i))) {
[error] [warn] 
[error] [warn] /.../sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala:323: org.apache.spark.sql.catalyst.expressions.codegen.Block and String are unrelated: they will most likely never compare equal
[error] [warn]          |  ${buildVars.filter(_.code == "").map(v => s"${v.isNull} = true;").mkString("\n")}
[error] [warn] 

Issue Links

• links to: [Github] Pull Request #22041 (ueshin)