[SPARK-22066] Update checkstyle to 8.2, enable it, fix violations

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0
• Component/s: Build
• Assignee: Sean R. Owen
• Reporter: Sean R. Owen
• Created: 19/Sep/17 20:07
• Updated: 13/Oct/17 07:40
• Resolved: 20/Sep/17 09:02

Description

While working on Scala 2.12 changes, I noted we could update various build plugins to their latest version, such as the scala-maven-plugin.

While doing that I noticed that the checkstyle plugin config had some bogus config, and that it was actually disabled and could be enabled now (build prints ERRORs but doesn't fail). This noise was making it a little hard to figure out what errors are real and new in the Scala 2.12 changes I'm working on, so should be fixed and stay fixed by being treated as errors.

And then I noted we could update checkstyle itself to 8.2, and fix existing and additional style errors.

Issue Links

• is duplicated by: SPARK-22269 Java style checks should be run in Jenkins
• links to: [Github] Pull Request #19282 (srowen)
• links to: [Github] Pull Request #19292 (srowen)