[SPARK-13747] Concurrent execution in SQL doesn't work with Scala ForkJoinPool

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0, 2.0.1
• Fix Version/s: 2.2.0
• Component/s: SQL
• Target Version/s: 2.0.2, 2.1.0
• Assignee: Shixiong Zhu
• Reporter: Shixiong Zhu
• Created: 08/Mar/16 19:07
• Updated: 18/May/17 00:22
• Resolved: 18/May/17 00:22

Description

Run the following codes may fail

(1 to 100).par.foreach { _ =>
  println(sc.parallelize(1 to 5).map { i => (i, i) }.toDF("a", "b").count())
}

java.lang.IllegalArgumentException: spark.sql.execution.id is already set 
        at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:87) 
        at org.apache.spark.sql.DataFrame.withNewExecutionId(DataFrame.scala:1904) 
        at org.apache.spark.sql.DataFrame.collect(DataFrame.scala:1385) 

This is because SparkContext.runJob can be suspended when using a ForkJoinPool (e.g.,scala.concurrent.ExecutionContext.Implicits.global) as it calls Await.ready (introduced by https://github.com/apache/spark/pull/9264).

So when SparkContext.runJob is suspended, ForkJoinPool will run another task in the same thread, however, the local properties has been polluted.

Issue Links

• is related to: SPARK-10548 Concurrent execution in SQL does not work
• relates to: SPARK-12964 SparkContext.localProperties leaked
• links to: [Github] Pull Request #11586 (andrewor14)
• links to: [Github] Pull Request #15520 (zsxwing)
• links to: [Github] Pull Request #15646 (zsxwing)
• links to: [Github] Pull Request #16230 (zsxwing)
• links to: [Github] Pull Request #17763 (zsxwing)