[SPARK-12308] Better onDisconnected logic for Master

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Incomplete
• Component/s: Spark Core
• Labels: bulk-closed
• Assignee: Unassigned
• Reporter: Shixiong Zhu
• Created: 13/Dec/15 06:06
• Updated: 21/May/19 04:36
• Resolved: 21/May/19 04:36

Description

Pasting vanzin's comment from GitHub(https://github.com/apache/spark/pull/10261#issuecomment-164107825):

That's because we took opposite approaches. Your PR's approach is "if this connection says the sender address is a listening socket, then also consider that address when sending events about the remote process".

My PR takes the opposite approach: the address of the remote process is always the address of the socket used to connect, regardless of whether its also listening in another socket.

I think my approach is in the end more correct, but requires more code to fix existing code. In my view, RpcCallContext.senderAddress should be the address of the socket that sent the message, not the address the remote process is listening on.