[SOLR-6597] SolrIndexConfig parameter in SolrIndexSearcher constructor is not used

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.10
• Fix Version/s: 5.0
• Assignee: Anshum Gupta
• Reporter: Anshum Gupta
• Created: 06/Oct/14 20:11
• Updated: 23/Feb/15 05:00
• Resolved: 31/Oct/14 17:02

Description

The following constructor of SolrIndexSearcher doesn't use 'config'.

SolrIndexSearcher

public SolrIndexSearcher(SolrCore core, String path, IndexSchema schema, SolrIndexConfig config, String name, DirectoryReader r, boolean closeReader, boolean enableCache, boolean reserveDirectory, DirectoryFactory directoryFactory)

It doesn't make sense to pass in the SolrIndexConfig when we're passing in the DirectoryReader (and asserting that it's never null). Prior to LUCENE-5666, when 'r' was null, the config was used to get a reader but not any more.

I'll just remove the param from the constructor and remove it from all places that calls this version of the constructor.