[SOLR-6519] In trunk change Solr's DirectoryFactory.create method to take LockFactory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0, 6.0
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 15/Sep/14 00:54
• Updated: 09/May/16 18:53
• Resolved: 17/Sep/14 18:31

Description

Because of NIO2 changes and the corresponding workaround, it is impossible now to create a Directory and "hope" that the lock factory directory is not created. Especially if you want some non-standard lock factory, this blows up.

The problem is: The lock dir is now created in ctor. As workaround I made all factories set NoLockFactory initially through ctor (see SOLR-6518), but this is just a workaround for incorrect API design.

In fact the main problem is just stupid: Why does protected CachingDirectoryFactory.create() not take the lock factory? I think its because of backwards compatibility, but with Solr 5.0 we can change this.

In future we want to make the lock factory non-mutable in Directory, so this is an important change. In addition, injectLockFactory looks horrible, this code is a häckidy-hick-hack!

Issue Links

• blocks: LUCENE-5953 Refactor LockFactory usage in Directory
• supercedes: SOLR-6518 CachingDirectoryFactory subclasses must init directory with NoLockFactory, because the real lock factory gets set later via injectLockFactory