[SOLR-6271] ConjunctionSolrSpellChecker wrong check for same string distance

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.9
• Fix Version/s: 5.5
• Component/s: spellchecker
• Assignee: James Dyer
• Reporter: Igor Kostromin
• Created: 24/Jul/14 07:16
• Updated: 18/Apr/17 16:08
• Resolved: 04/Dec/15 18:36

Description

See ConjunctionSolrSpellChecker.java

try {
if (stringDistance == null)

{ stringDistance = checker.getStringDistance(); }

else if (stringDistance != checker.getStringDistance())

{ throw new IllegalArgumentException( "All checkers need to use the same StringDistance."); }

} catch (UnsupportedOperationException uoe)

{ // ignore }

In line stringDistance != checker.getStringDistance() there is comparing by references. So if you are using 2 or more spellcheckers with same distance algorithm, exception will be thrown anyway.

Issue Links

• is cloned by: SOLR-10513 CLONE - ConjunctionSolrSpellChecker wrong check for same string distance