[SOLR-2027] SolrJ FacetField should never return null from getValues()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 4.0-ALPHA
• Component/s: clients - java
• Assignee: Chris Male
• Reporter: David Smiley
• Created: 04/Aug/10 19:11
• Updated: 10/May/13 10:39
• Resolved: 09/Jul/11 00:50

Description

In some circumstances, FacetField.getValues() will return null. I'd like for my iteration code to simply be:

for (c : ff.getValues() { 
  // ...
}

However this will throw an NPE if I don't wrap this in either a null check or this check: ff.getValueCount() > 0

I propose that getValues() return a Collections.EMPTY_LIST if the internal value is null.