[SOLR-1962] Index directory disagreement SolrCore#initIndex

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4, 1.4.1
• Fix Version/s: 3.1, 4.0-ALPHA
• Assignee: Mark Miller
• Reporter: Mark Miller
• Created: 18/Jun/10 00:43
• Updated: 30/Mar/11 15:45
• Resolved: 13/Feb/11 23:47

Description

getNewIndexDir is widely used in this method - but then when a new index is created, getIndexDir is used:

      // Create the index if it doesn't exist.
      if(!indexExists) {
        log.warn(logid+"Solr index directory '" + new File(getNewIndexDir()) + "' doesn't exist."
                + " Creating new index...");

        SolrIndexWriter writer = new SolrIndexWriter("SolrCore.initIndex", getIndexDir(), getDirectoryFactory(), true, schema, solrConfig.mainIndexConfig, solrDelPolicy);
        writer.close();
      }

also this piece uses getIndexDir():

      if (indexExists && firstTime && removeLocks) {
        // to remove locks, the directory must already exist... so we create it
        // if it didn't exist already...
        Directory dir = SolrIndexWriter.getDirectory(getIndexDir(), getDirectoryFactory(), solrConfig.mainIndexConfig);
        if (dir != null)  {
          if (IndexWriter.isLocked(dir)) {
            log.warn(logid+"WARNING: Solr index directory '" + getIndexDir() + "' is locked.  Unlocking...");
            IndexWriter.unlock(dir);
          }
          dir.close();
        }
      }