Details
-
Task
-
Status: Resolved
-
Major
-
Resolution: Won't Fix
-
None
-
None
-
None
-
None
-
Just spent a couple of hours trying to figure out why my latest attempt to merge master into the gradle build failed with a precommit warning about
Forbidden method invocation: java.lang.Math#toRadians(double) [Use home-grown methods instead] in org.apache.lucene.geo.Rectangle (Rectangle.java:155)
It turns out that we keep copies of "shared" resources in buildSrc, specifically in this case there are now two copies of some files in Git, in this case:
./lucene/tools/forbiddenApis/lucene.txt
./buildSrc/src/main/resources/forbidden/lucene.txtThis one was recently changed to remove a couple of entries on master:
./lucene/tools/forbiddenApis/lucene.txtBut this one is unchanged:
./buildSrc/src/main/resources/forbidden/lucene.txtI can find no targets that update this automagically.
Just spent a couple of hours trying to figure out why my latest attempt to merge master into the gradle build failed with a precommit warning about Forbidden method invocation: java.lang. Math #toRadians( double ) [Use home-grown methods instead] in org.apache.lucene.geo.Rectangle (Rectangle.java:155) It turns out that we keep copies of "shared" resources in buildSrc, specifically in this case there are now two copies of some files in Git, in this case: ./lucene/tools/forbiddenApis/lucene.txt ./buildSrc/src/main/resources/forbidden/lucene.txt This one was recently changed to remove a couple of entries on master: ./lucene/tools/forbiddenApis/lucene.txt But this one is unchanged: ./buildSrc/src/main/resources/forbidden/lucene.txt I can find no targets that update this automagically.
Attachments
Issue Links
- is part of
-
SOLR-13914 Umbrella issue for updating the build system to use Gradle
- Resolved