[SOLR-13209] NullPointerException from call in org.apache.solr.search.SolrIndexSearcher.getDocSet

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 9.0
• Fix Version/s: 9.0, 8.10
• Labels: diffblue newdev

Environment

Steps to reproduce

• Use a Linux machine.
• Build commit ea2c8ba of Solr as described in the section below.
• Build the films collection as described below.
• Start the server using the command ./bin/solr start -f -p 8983 -s /tmp/home
• Request the URL given in the bug description.

Compiling the server

git clone https://github.com/apache/lucene-solr
cd lucene-solr
git checkout ea2c8ba
ant compile
cd solr
ant server

Building the collection and reproducing the bug

We followed Exercise 2 from the Solr Tutorial.

mkdir -p /tmp/home
echo '<?xml version="1.0" encoding="UTF-8" ?><solr></solr>' > /tmp/home/solr.xml

In one terminal start a Solr instance in foreground:

./bin/solr start -f -p 8983 -s /tmp/home

In another terminal, create a collection of movies, with no shards and no replication, and initialize it:

bin/solr create -c films
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-field": {"name":"name", "type":"text_general", "multiValued":false, "stored":true}}' http://localhost:8983/solr/films/schema
curl -X POST -H 'Content-type:application/json' --data-binary '{"add-copy-field" : {"source":"*","dest":"_text_"}}' http://localhost:8983/solr/films/schema
./bin/post -c films example/films/films.json
curl -v “URL_BUG”

Please check the issue description below to find the “URL_BUG” that will allow you to reproduce the issue reported.

• Assignee: Mike Drob
• Reporter: Cesar Rodriguez
• Created: 31/Jan/19 18:30
• Updated: 28/Sep/21 20:22
• Resolved: 31/Aug/21 15:24

Description

Requesting the following URL causes Solr to return an HTTP 500 error response:

http://localhost:8983/solr/films/select?group=true&group.query

The error response seems to be caused by the following uncaught exception:

 java.lang.NullPointerException
	at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936)
	at org.apache.solr.util.ConcurrentLRUCache.get(ConcurrentLRUCache.java:124)
	at org.apache.solr.search.FastLRUCache.get(FastLRUCache.java:163)
	at org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:792)
	at org.apache.solr.search.Grouping$CommandQuery.createFirstPassCollector(Grouping.java:860)
	at org.apache.solr.search.Grouping.execute(Grouping.java:327)
	at org.apache.solr.handler.component.QueryComponent.doProcessGroupedSearch(QueryComponent.java:1408)
	at org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:365)
	at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:298)
	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:199)
	at org.apache.solr.core.SolrCore.execute(SolrCore.java:2559)
[...]

Method org.apache.solr.search.SolrIndexSearcher.getDocSet(), at line 792 calls filterCache.get(absQ) where absQ is a null pointer. I think this null pointer comes in fact from the caller, but I don't fully follow the logic of the code.

To set up an environment to reproduce this bug, follow the description in the ‘Environment’ field.

We automatically found this issue and ~70 more like this using Diffblue Microservices Testing. Find more information on this fuzz testing campaign.

Issue Links

• relates to: SOLR-8319 NPE when creating pivot
• links to: GitHub Pull Request #273
• links to: Github Pull Request #273
• links to: GitHub Pull Request #937