[SOLR-12594] MetricsHistoryHandler.getOverseerLeader fails when hostname contains hyphen

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 7.4
• Fix Version/s: 7.4.1, 7.5
• Component/s: metrics
• Assignee: Andrzej Bialecki
• Reporter: Chris M. Hostetter
• Created: 25/Jul/18 18:08
• Updated: 08/Jun/19 15:00
• Resolved: 29/Aug/18 06:50

Description

as reported on the user list...

We encounter a lot of log warning entries from the MetricsHistoryHandler saying

o.a.s.h.a.MetricsHistoryHandler Unknown format of leader id, skipping:
244550997187166214-server1-b.myhost:8983_solr-n_0000000094

I don't even know what this MetricsHistoryHandler does, but at least there's a warning.

Looking at the code you can see that it has to fail if the hostname of the node contains a hyphen:

String[] ids = oid.split("-");
if (ids.length != 3) { // unknown format
  log.warn("Unknown format of leader id, skipping: " + oid);
  return null;
}