[SM-182] JmsReceicerComponent destroy method can use less JMS close() calls

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.1
• Fix Version/s: 2.0.2
• Component/s: servicemix-components
• Assignee: Unassigned
• Reporter: Peter Samuelson
• Created: 14/Nov/05 21:40
• Updated: 17/Nov/05 01:16
• Resolved: 17/Nov/05 01:16

Description

In JMS the connection close() also closes all sessions, consumers/producers
In JMS the session close() also closes all consumers/producers

See
http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/jms/Connection.html#close()
http://java.sun.com/j2ee/sdk_1.3/techdocs/api/javax/jms/Session.html#close()

SInce this component is closing everything, really a successful connection.close() is all that is needed. So the JmsReceiverComponent destroy() method can be written to make less API calls as follows:

public void destroy() throws Exception {
//PS Fix: START
/*
if (consumer != null)

{ consumer.close(); consumer = null; }

if (session != null)

{ session.close(); session = null; }

if (connection != null)

{ connection.close(); connection = null; }

*/
try {
if (connection != null)

{ connection.close(); }

else if (session != null)

{ session.close(); }

else if (consumer != null)

{ consumer.close(); }

} finally

{ connection = null; session = null; consumer = null; }

//PS Fix: END
}