Uploaded image for project: 'Sling'
  1. Sling
  2. SLING-6756

Remove setting/advising to set permsize and max heap size

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • None
    • None
    • None
    • None

    Description

      PermSize is no longer an issue with java 8 as Java 8 no longer knows a dedicated permgen space (https://dzone.com/articles/java-8-permgen-metaspace). Still we set -XX:MaxPermSize=256m in https://github.com/apache/sling/blob/trunk/.mvn/jvm.config (SLING-4530) which leads to a warning when building with Java 8.

      The related ant check in parent has been removed though in https://issues.apache.org/jira/browse/SLING-5862. Althought the reason why the check has been removed is a bit unclear to me from the comments, I would propose to remove the jvm.config completely and do no longer advise to set permsize or heapsize explicitly.

      The heapsize is currently bound to at most 512MB, which is in 90% of the cases just limiting the maximum heapsize of a modern JVM (because it should be 1/4 of the physical memory in most of the JVM, see http://stackoverflow.com/questions/4667483/how-is-the-default-java-heap-size-determined).

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              kwin Konrad Windszus
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: