[SENTRY-2047] isTableEmptyCore method in SentryStore has references to MAuthzPathsMapping when it should be generic

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: Sentry
• Labels: newbie
• Assignee: Arjun Mishra
• Reporter: Arjun Mishra
• Created: 15/Nov/17 16:49
• Updated: 20/Nov/17 21:16
• Resolved: 17/Nov/17 17:04

Description

Current isTableEmpty implementation is below

private boolean isTableEmptyCore(PersistenceManager pm, Class clazz) {
    Query query = pm.newQuery(clazz);
    query.addExtension(LOAD_RESULTS_AT_COMMIT, "false");
    // setRange is implemented efficiently for MySQL, Postgresql (using the LIMIT SQL keyword)
    // and Oracle (using the ROWNUM keyword), with the query only finding the objects required
    // by the user directly in the datastore. For other RDBMS the query will retrieve all
    // objects up to the "to" record, and will not pass any unnecessary objects that are before
    // the "from" record.
    query.setRange(0, 1);
    return ((List<MAuthzPathsMapping>) query.execute()).isEmpty();
  }

We seem to be casting query.execute to a List<MAuthzPathsMapping> when there is no need for it

Issue Links

• links to: Review board link