[SENTRY-1946] getPathsUpdatesFrom() got its boolean logic inversed which results in sending two snapshots at the same time

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Assignee: Vamsee K. Yarlagadda
• Reporter: Vamsee K. Yarlagadda
• Created: 12/Sep/17 00:38
• Updated: 12/Sep/17 03:00
• Resolved: 12/Sep/17 03:00

Description

As part of SENTRY-1931, we added check not to send two NN snaphsots at the same time. But because of a conditional typo, it results in sending back two snapshots.

    // If another paths updates request is in progress by another HDFS NameNode, then we
    // return an empty image for now to avoid a large memory consumption
    if (pathsRetrieverBusy.compareAndSet(false, true)) {
      LOGGER.debug("PATHS updates are not available because another request is in progress.");
      return Collections.emptyList();
    }

Issue Links

• is duplicated by: SENTRY-1945 getPathsUpdatesFrom() got its boolean logic inversed