[SENTRY-1662] Constants java uses mutable collection

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Steve Moist
• Reporter: Alex Kolbasov
• Created: 15/Mar/17 06:28
• Updated: 14/Dec/17 18:15
• Resolved: 14/Dec/17 18:15

Description

Constants.java has the following code:

  public static final Map<String, String> requestTypeToOperationMap = new HashMap<String, String>();
  public static final Map<String, String> requestTypeToObjectTypeMap = new HashMap<String, String>();

  static {
    // for hive audit log
    requestTypeToOperationMap.put(TCreateSentryRoleRequest.class.getName(),
        Constants.OPERATION_CREATE_ROLE);
    requestTypeToOperationMap.put(
        TAlterSentryRoleGrantPrivilegeRequest.class.getName(),
        Constants.OPERATION_GRANT_PRIVILEGE);
...

Instead it should create immutable maps for these.