[SAMZA-1760] SystemAdmin is not started properly in a few places

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 0.14.1
• Assignee: Unassigned
• Reporter: Cameron Lee
• Created: 26/Jun/18 01:59
• Updated: 22/Jul/19 20:54

Description

https://github.com/apache/samza/pull/397 added a "start" and "stop" to the SystemAdmin interface. Most places got updated to manage the lifecycle. However, a few places were missed (or other changes were made more recently that did not correctly manage the lifecycle):

1. CoordinatorStreamSystemConsumer starts a SystemAdmin in its "start" method. However, it uses SystemAdmin.getSystemStreamMetadata in "register", which is called before "start". This class properly stops SystemAdmin.
2. SystemConsumerBench does not start/stop the SystemAdmin.
3. TestRunner does not start/stop the SystemAdmin.

Issue Links

• links to: GitHub Pull Request #564
• links to: GitHub Pull Request #564