[SAMZA-1756] System exit calls in ApplicationRunnerMain break ProcessJob and cause unit tests to get skipped

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.15
• Fix Version/s: 1.0
• Assignee: Cameron Lee
• Reporter: Cameron Lee
• Created: 22/Jun/18 18:15
• Updated: 26/Feb/19 00:53
• Resolved: 22/Jun/18 22:49

Description

A recent change from SAMZA-1724 introduced a System.exit call at the end of ApplicationRunnerMain. However, ProcessJob has a non-daemon thread that needs to stay alive in order to deploy the container and then shut down the job model manager after the container shuts down.

The System.exit will either:

1. Kill the ProcessJob thread before it can start the process
2. Kill the job model manager from ProcessJobFactory, so the new container process (if it does get started) is unable to reach the coordinator to get configs

Also, this System.exit causes the execution of unit tests to stop early because the main method is called in TestApplicationRunnerMain. The Thread.setDefaultUncaughtExceptionHandler also causes test execution to exit incorrectly, since that handler seems to get triggered by some other test.

From what I can tell, the ApplicationRunnerMain changes are there to be defensive, but there was no explicit case that it was fixing right now. For now, we can revert those changes until we know how to solve these issues.

Issue Links

• links to: GitHub Pull Request #561