[SAMZA-1754] Improve validation error messages in StreamSpec

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0
• Assignee: Unassigned
• Reporter: Jagadish
• Created: 21/Jun/18 23:56
• Updated: 26/Feb/19 00:53
• Resolved: 02/Oct/18 17:01

Description

Often, there are validation failures due to a misconfigured StreamSpec. Here's one such example:

Caused by: java.lang.IllegalArgumentException: Identifier 'systemName' is 'null'. It must match the expression [A-Za-z0-9_-]+ 
    at org.apache.samza.system.StreamSpec.validateLogicalIdentifier(StreamSpec.java:245) 
    at org.apache.samza.system.StreamSpec.<init>(StreamSpec.java:163) 
    at org.apache.samza.system.StreamSpec.<init>(StreamSpec.java:140) 
    at org.apache.samza.runtime.AbstractApplicationRunner.getStreamSpec(AbstractApplicationRunner.java:119) 
    at org.apache.samza.runtime.AbstractApplicationRunner.getStreamSpec(AbstractApplicationRunner.java:100) 
    at org.apache.samza.runtime.AbstractApplicationRunner.getStreamSpec(AbstractApplicationRunner.java:65) 
    at org.apache.samza.operators.StreamGraphImpl.getInputStream(StreamGraphImpl.java:91) 
    at org.apache.samza.operators.StreamGraphImpl.getInputStream(StreamGraphImpl.java:117) 
    at com.linkedin.actioncommon.ams.samza.AccountManagementStreamApplication.init(AccountManagementStreamApplication.java:31) 
    at org.apache.samza.runtime.AbstractApplicationRunner.getExecutionPlan(AbstractApplicationRunner.java:131) 
    at org.apache.samza.runtime.AbstractApplicationRunner.getExecutionPlan(AbstractApplicationRunner.java:124) 
    at org.apache.samza.runtime.LocalApplicationRunner.run(LocalApplicationRunner.java:152) 
 

The error message should have adequate context:
1. What was the topicName, streamId, numPartitions, physicalName, numPartitions in the StreamSpec being validated?

Issue Links

• links to: GitHub Pull Request #598