[SAMZA-1548] Add start() and stop() to SystemAdmin

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.14.1
• Assignee: Dong Lin
• Reporter: Dong Lin
• Created: 02/Jan/18 18:49
• Updated: 02/May/18 16:53
• Resolved: 30/Jan/18 21:25

Description

This patch adds start() and stop() to SystemAdmin interface. This can be useful for e.g. kafka.admin.AdminClient which needs to be started before it can be used.

Since we add this method in interface and expect AdminClient to be stateful and probably has its own thread, there will be higher cost to instantiate a new SystemAdmin. Thus we probably want to re-use the SystemAdmin instances instead of creating SystemAdmin on demand when needed. Therefore, this patch also adds SystemAdmins class to help manage a map from system to SystemAdmin, similar to the existing SystemProducers class in Samza.

Issue Links

• links to: GitHub Pull Request #397