[SAMZA-1347] GroupByContainerIds NPE if containerIds list is null

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.13.1
• Assignee: Jake Maes
• Reporter: Jake Maes
• Created: 26/Jun/17 22:38
• Updated: 27/Jun/17 18:54
• Resolved: 27/Jun/17 18:54

Description

Another low-hanging fruit. The null check in group() happens AFTER checking the size of containerIds. These statements should be reordered.

Also, Since the group(tasks) method always calls the group(tasks, containerIds) method, lets just move all the safety checks there.

Issue Links

• links to: GitHub Pull Request #233