[POOL-298] Wrong jmxNameBase default value, unable to set jmxNamePrefix

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0, 2.1, 2.2, 2.3, 2.4.1
• Fix Version/s: 2.4.2
• Assignee: Unassigned
• Reporter: Bastien Colmard
• Created: 04/Jun/15 12:35
• Updated: 06/Aug/15 22:57
• Resolved: 28/Jul/15 00:16

Description

We needed to define our own pool names for Redis, to be able to know which pool was throwing errors, but we experienced some difficulties.
We use jedis-2.7.2, which uses commons-pool2-2.3 configured with spring beans. After setting a custom jmxNamePrefix, we didn't notice any difference and proceeded to debug.

To my understanding, BaseGenericObjectPool.jmxRegister uses BaseObjectPoolConfig.jmxNameBase to build its ObjectName, but jmxNameBase defaults to jmxNamePrefix which is "pool" (not a valid domain) and throws a MalformedObjectNameException, falling back to "org.apache.commons.pool2:type=GenericKeyedObjectPool,name=pool".

The current workaround is to force jmxNameBase to null with

<property name="jmxNameBase"><null/></property>

The fix would be
https://github.com/apache/commons-pool/blob/trunk/src/main/java/org/apache/commons/pool2/impl/BaseObjectPoolConfig.java#L192 (introduced in December 2013 it seems)

-private String jmxNameBase = DEFAULT_JMX_NAME_PREFIX
+private String jmxNameBase = DEFAULT_JMX_NAME_BASE

I can submit a Pull Request on Github but it looks like you only use it as a mirror