[POOL-263] GenericObjectPool close and returnObject is not synchronized

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2
• Fix Version/s: 2.3

Environment

ALL

• Assignee: Unassigned
• Reporter: yangxuesong
• Created: 16/Apr/14 04:01
• Updated: 31/Dec/14 16:18
• Resolved: 09/Jul/14 21:30

Description

the javadoc on GenericObjectPool#close() says:
"Closes the pool. Once the pool is closed, borrowObject() will fail with IllegalStateException, but returnObject(Object) and invalidateObject(Object) will continue to work, with returned objects destroyed on return.
Destroys idle instances in the pool by invoking clear()."
Thread1: pool.close()
Thread2: pool.returnObject()
since close and returnObject is not synchronized, there is a small chance that an returned object is not destoryed after the pool is closed