[POOL-196] PooledObject.getActiveTimeMillis() does not synch. access to lastReturnTime and lastBorrowTime

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 13/Dec/11 01:10
• Updated: 31/Dec/14 16:29
• Resolved: 13/Dec/11 15:18

Description

The method PooledObject.getActiveTimeMillis() compares lastReturnTime and lastBorrowTime, but is not synchronised; nor are the variables volatile.

There are two possible thread issues here: safe publication of the variables, and possible window error when comparing the values.

The method needs to be synch. and the fields need to be volatile (or the getters need to be synch.)