[POOL-158] References to GenericKeyedObjectPool._minIdle are not always synchronized

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2, 1.4, 1.5, 1.5.1, 1.5.2, 1.5.3, 1.5.4
• Fix Version/s: 1.5.5
• Assignee: Unassigned
• Reporter: Sebb
• Created: 08/Feb/10 17:37
• Updated: 12/Sep/10 17:24
• Resolved: 06/Jun/10 20:41

Description

References to GenericKeyedObjectPool._minIdle are not always synchronized:

The ensureMinIdle() and evict() methods both access the field outside the synch. block.
This is particularly bad as they are called from the timer thread.

The references could use getMinIdle(), which is synch., or it would probably be cheaper to move the references into the synch. blocks.

Better yet, can the field be made final? setMinIdle() is currently only called from Test cases and setConfig() which is not referenced AFAICT.